Phase 3: Session recording/playback and encrypted profile export/import
Session Recording & Playback: - Add recording package with asciicast v2 format writer and reader - Recorder captures terminal I/O with timestamps from SSH and Telnet sessions - Input and output events recorded via hooks in session manager callbacks - Recording store manages .cast files in ~/Library/Application Support/NexusTerminal/recordings - Recording browser modal lists all saved recordings with metadata - Full playback viewer with embedded xterm.js terminal, progress scrubber, play/pause/restart controls, and 0.5x-10x speed adjustment - Recording indicator (pulsing red dot) shown on active tab during capture - Keyboard shortcut Cmd+Shift+R to toggle recording on active session - Tests for recording, store listing, deletion, and double-close safety Encrypted Profile Export/Import: - Add exportimport package with AES-256-GCM encryption (Argon2id key derivation) - File format: version byte + 32-byte salt + 12-byte nonce + ciphertext - Same Argon2id parameters as vault (128 MiB, 3 iterations, 4 threads) - Export modal with profile selection checkboxes and password entry - Import modal with password entry and conflict strategy (skip/overwrite/duplicate) - Native save/open file dialogs for .nexus files - Tests for round-trip encryption, wrong password rejection, corrupt files - Replaced placeholder import/export with full encrypted implementation UI: - Added export and recordings buttons to sidebar footer - Recording and playback CSS with charcoal design tokens - Wired RecordingManager and ExportImportUI into app.js
This commit is contained in:
@@ -0,0 +1,188 @@
|
||||
// Package exportimport provides encrypted profile export and import.
|
||||
// Profiles are serialised to JSON, then encrypted with AES-256-GCM using
|
||||
// an Argon2id-derived key from a user-supplied password. No hard-coded
|
||||
// secrets are used. The file format includes a version byte, salt, nonce,
|
||||
// and ciphertext — everything needed for self-contained decryption.
|
||||
package exportimport
|
||||
|
||||
import (
|
||||
"crypto/aes"
|
||||
"crypto/cipher"
|
||||
"crypto/rand"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"time"
|
||||
|
||||
"golang.org/x/crypto/argon2"
|
||||
|
||||
"github.com/copilot-ssh-client/app/internal/models"
|
||||
)
|
||||
|
||||
const (
|
||||
// File format version. Increment if the envelope format changes.
|
||||
formatVersion byte = 1
|
||||
|
||||
// Argon2id parameters for export encryption (same strength as the vault).
|
||||
exportArgonTime = 3
|
||||
exportArgonMemory = 128 * 1024 // 128 MiB
|
||||
exportArgonThreads = 4
|
||||
exportArgonKeyLen = 32 // AES-256
|
||||
|
||||
saltLength = 32
|
||||
nonceLength = 12 // AES-GCM standard nonce size
|
||||
)
|
||||
|
||||
// ExportBundle is the cleartext payload that gets encrypted.
|
||||
type ExportBundle struct {
|
||||
Version int `json:"version"`
|
||||
ExportedAt string `json:"exportedAt"` // ISO 8601
|
||||
Profiles []models.Profile `json:"profiles"`
|
||||
Count int `json:"count"`
|
||||
}
|
||||
|
||||
// EncryptAndExport serialises the given profiles, encrypts the JSON with
|
||||
// AES-256-GCM (Argon2id-derived key), and writes the result to the file.
|
||||
//
|
||||
// File layout: [1 byte version][32 bytes salt][12 bytes nonce][ciphertext]
|
||||
func EncryptAndExport(profiles []models.Profile, password, filePath string) error {
|
||||
if password == "" {
|
||||
return errors.New("exportimport: password cannot be empty")
|
||||
}
|
||||
if len(profiles) == 0 {
|
||||
return errors.New("exportimport: no profiles to export")
|
||||
}
|
||||
|
||||
bundle := ExportBundle{
|
||||
Version: 1,
|
||||
ExportedAt: time.Now().UTC().Format(time.RFC3339),
|
||||
Profiles: profiles,
|
||||
Count: len(profiles),
|
||||
}
|
||||
|
||||
plaintext, err := json.MarshalIndent(bundle, "", " ")
|
||||
if err != nil {
|
||||
return fmt.Errorf("exportimport: failed to serialise profiles: %w", err)
|
||||
}
|
||||
|
||||
// Generate random salt and nonce.
|
||||
salt := make([]byte, saltLength)
|
||||
if _, err := io.ReadFull(rand.Reader, salt); err != nil {
|
||||
return fmt.Errorf("exportimport: failed to generate salt: %w", err)
|
||||
}
|
||||
|
||||
nonce := make([]byte, nonceLength)
|
||||
if _, err := io.ReadFull(rand.Reader, nonce); err != nil {
|
||||
return fmt.Errorf("exportimport: failed to generate nonce: %w", err)
|
||||
}
|
||||
|
||||
// Derive encryption key from password.
|
||||
key := argon2.IDKey(
|
||||
[]byte(password),
|
||||
salt,
|
||||
exportArgonTime,
|
||||
exportArgonMemory,
|
||||
exportArgonThreads,
|
||||
exportArgonKeyLen,
|
||||
)
|
||||
|
||||
// Encrypt with AES-256-GCM.
|
||||
block, err := aes.NewCipher(key)
|
||||
if err != nil {
|
||||
return fmt.Errorf("exportimport: cipher init failed: %w", err)
|
||||
}
|
||||
|
||||
gcm, err := cipher.NewGCM(block)
|
||||
if err != nil {
|
||||
return fmt.Errorf("exportimport: GCM init failed: %w", err)
|
||||
}
|
||||
|
||||
ciphertext := gcm.Seal(nil, nonce, plaintext, nil)
|
||||
|
||||
// Write the file: version + salt + nonce + ciphertext.
|
||||
f, err := os.Create(filePath)
|
||||
if err != nil {
|
||||
return fmt.Errorf("exportimport: failed to create file: %w", err)
|
||||
}
|
||||
defer f.Close()
|
||||
|
||||
if _, err := f.Write([]byte{formatVersion}); err != nil {
|
||||
return fmt.Errorf("exportimport: write version failed: %w", err)
|
||||
}
|
||||
if _, err := f.Write(salt); err != nil {
|
||||
return fmt.Errorf("exportimport: write salt failed: %w", err)
|
||||
}
|
||||
if _, err := f.Write(nonce); err != nil {
|
||||
return fmt.Errorf("exportimport: write nonce failed: %w", err)
|
||||
}
|
||||
if _, err := f.Write(ciphertext); err != nil {
|
||||
return fmt.Errorf("exportimport: write ciphertext failed: %w", err)
|
||||
}
|
||||
|
||||
return f.Sync()
|
||||
}
|
||||
|
||||
// DecryptAndImport reads an encrypted export file, decrypts it using the
|
||||
// given password, and returns the contained profiles.
|
||||
func DecryptAndImport(filePath, password string) ([]models.Profile, error) {
|
||||
if password == "" {
|
||||
return nil, errors.New("exportimport: password cannot be empty")
|
||||
}
|
||||
|
||||
data, err := os.ReadFile(filePath)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("exportimport: failed to read file: %w", err)
|
||||
}
|
||||
|
||||
// Minimum size: version(1) + salt(32) + nonce(12) + at least 1 byte ciphertext + GCM tag(16).
|
||||
minSize := 1 + saltLength + nonceLength + 1 + 16
|
||||
if len(data) < minSize {
|
||||
return nil, errors.New("exportimport: file is too small or corrupt")
|
||||
}
|
||||
|
||||
// Parse envelope.
|
||||
version := data[0]
|
||||
if version != formatVersion {
|
||||
return nil, fmt.Errorf("exportimport: unsupported format version %d", version)
|
||||
}
|
||||
|
||||
salt := data[1 : 1+saltLength]
|
||||
nonce := data[1+saltLength : 1+saltLength+nonceLength]
|
||||
ciphertext := data[1+saltLength+nonceLength:]
|
||||
|
||||
// Derive decryption key.
|
||||
key := argon2.IDKey(
|
||||
[]byte(password),
|
||||
salt,
|
||||
exportArgonTime,
|
||||
exportArgonMemory,
|
||||
exportArgonThreads,
|
||||
exportArgonKeyLen,
|
||||
)
|
||||
|
||||
// Decrypt with AES-256-GCM.
|
||||
block, err := aes.NewCipher(key)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("exportimport: cipher init failed: %w", err)
|
||||
}
|
||||
|
||||
gcm, err := cipher.NewGCM(block)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("exportimport: GCM init failed: %w", err)
|
||||
}
|
||||
|
||||
plaintext, err := gcm.Open(nil, nonce, ciphertext, nil)
|
||||
if err != nil {
|
||||
return nil, errors.New("exportimport: decryption failed — wrong password or corrupt file")
|
||||
}
|
||||
|
||||
// Parse the JSON bundle.
|
||||
var bundle ExportBundle
|
||||
if err := json.Unmarshal(plaintext, &bundle); err != nil {
|
||||
return nil, fmt.Errorf("exportimport: invalid bundle JSON: %w", err)
|
||||
}
|
||||
|
||||
return bundle.Profiles, nil
|
||||
}
|
||||
@@ -0,0 +1,131 @@
|
||||
package exportimport
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/copilot-ssh-client/app/internal/models"
|
||||
)
|
||||
|
||||
func TestEncryptDecryptRoundTrip(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "test-export.nexus")
|
||||
|
||||
profiles := []models.Profile{
|
||||
{
|
||||
ID: "test-1",
|
||||
DisplayName: "Test Server",
|
||||
Protocol: models.ProtocolSSH,
|
||||
Host: "example.com",
|
||||
Port: 22,
|
||||
Username: "admin",
|
||||
},
|
||||
{
|
||||
ID: "test-2",
|
||||
DisplayName: "Dev Box",
|
||||
Protocol: models.ProtocolSSH,
|
||||
Host: "dev.example.com",
|
||||
Port: 2222,
|
||||
Username: "developer",
|
||||
},
|
||||
}
|
||||
|
||||
password := "strong-test-password-2024!"
|
||||
|
||||
// Encrypt and export.
|
||||
if err := EncryptAndExport(profiles, password, path); err != nil {
|
||||
t.Fatalf("EncryptAndExport failed: %v", err)
|
||||
}
|
||||
|
||||
// Verify file exists and has content.
|
||||
info, err := os.Stat(path)
|
||||
if err != nil {
|
||||
t.Fatalf("exported file not found: %v", err)
|
||||
}
|
||||
if info.Size() == 0 {
|
||||
t.Fatal("exported file is empty")
|
||||
}
|
||||
|
||||
// Decrypt and import.
|
||||
imported, err := DecryptAndImport(path, password)
|
||||
if err != nil {
|
||||
t.Fatalf("DecryptAndImport failed: %v", err)
|
||||
}
|
||||
|
||||
if len(imported) != len(profiles) {
|
||||
t.Fatalf("expected %d profiles, got %d", len(profiles), len(imported))
|
||||
}
|
||||
|
||||
for i, p := range imported {
|
||||
if p.ID != profiles[i].ID {
|
||||
t.Errorf("profile %d: expected ID %q, got %q", i, profiles[i].ID, p.ID)
|
||||
}
|
||||
if p.DisplayName != profiles[i].DisplayName {
|
||||
t.Errorf("profile %d: expected DisplayName %q, got %q", i, profiles[i].DisplayName, p.DisplayName)
|
||||
}
|
||||
if p.Host != profiles[i].Host {
|
||||
t.Errorf("profile %d: expected Host %q, got %q", i, profiles[i].Host, p.Host)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestDecryptWrongPassword(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "test-export.nexus")
|
||||
|
||||
profiles := []models.Profile{
|
||||
{
|
||||
ID: "test-1",
|
||||
DisplayName: "Test",
|
||||
Protocol: models.ProtocolSSH,
|
||||
Host: "example.com",
|
||||
Port: 22,
|
||||
},
|
||||
}
|
||||
|
||||
if err := EncryptAndExport(profiles, "correct-password", path); err != nil {
|
||||
t.Fatalf("EncryptAndExport failed: %v", err)
|
||||
}
|
||||
|
||||
_, err := DecryptAndImport(path, "wrong-password")
|
||||
if err == nil {
|
||||
t.Fatal("expected error with wrong password, got nil")
|
||||
}
|
||||
}
|
||||
|
||||
func TestEncryptEmptyProfiles(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "test.nexus")
|
||||
|
||||
err := EncryptAndExport(nil, "password", path)
|
||||
if err == nil {
|
||||
t.Fatal("expected error for empty profiles, got nil")
|
||||
}
|
||||
}
|
||||
|
||||
func TestEncryptEmptyPassword(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "test.nexus")
|
||||
|
||||
profiles := []models.Profile{{ID: "1"}}
|
||||
err := EncryptAndExport(profiles, "", path)
|
||||
if err == nil {
|
||||
t.Fatal("expected error for empty password, got nil")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDecryptCorruptFile(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
path := filepath.Join(dir, "corrupt.nexus")
|
||||
|
||||
// Write garbage data.
|
||||
if err := os.WriteFile(path, []byte("corrupt"), 0600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
_, err := DecryptAndImport(path, "password")
|
||||
if err == nil {
|
||||
t.Fatal("expected error for corrupt file, got nil")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user