Add edit button to sidebar items and fix initial terminal fit
- Add pencil edit button on each sidebar profile item (visible on hover) - Fire fitAddon.fit() multiple times after terminal creation (50/150/400ms) to catch the panel finishing its CSS layout - Re-fit terminal when session:state transitions to 'connected'
This commit is contained in:
@@ -134,6 +134,10 @@ class App {
|
||||
window.runtime.EventsOn('session:state', (payload) => {
|
||||
this.tabs.updateSessionState(payload.sessionID, payload.state, payload.error);
|
||||
this.updateStatusBar();
|
||||
// Re-fit the terminal once connected so it picks up the final container size
|
||||
if (payload.state === 'connected') {
|
||||
setTimeout(() => this.terminals.fitActive(), 50);
|
||||
}
|
||||
});
|
||||
|
||||
// Session closed by backend
|
||||
|
||||
@@ -170,6 +170,17 @@ class Sidebar {
|
||||
textWrapper.appendChild(subEl);
|
||||
item.appendChild(textWrapper);
|
||||
|
||||
// Edit button (visible on hover)
|
||||
const editBtn = createElement('button', 'sidebar-item-edit', {
|
||||
textContent: '✎',
|
||||
title: 'Edit profile',
|
||||
});
|
||||
editBtn.addEventListener('click', (e) => {
|
||||
e.stopPropagation();
|
||||
this.app.profileEditor.openEdit(profile.id);
|
||||
});
|
||||
item.appendChild(editBtn);
|
||||
|
||||
// Favourite star
|
||||
if (profile.favourite) {
|
||||
const star = createElement('span', 'sidebar-item-star is-favourite', { textContent: '★' });
|
||||
|
||||
@@ -67,8 +67,14 @@ class TerminalManager {
|
||||
const container = document.getElementById(containerId);
|
||||
term.open(container);
|
||||
|
||||
// Initial fit
|
||||
requestAnimationFrame(() => fitAddon.fit());
|
||||
// Fit the terminal once the container has had time to lay out.
|
||||
// A single requestAnimationFrame is not enough — the panel may
|
||||
// still be transitioning from display:none, so we retry briefly.
|
||||
const doFit = () => { try { fitAddon.fit(); } catch (_) { /* noop */ } };
|
||||
requestAnimationFrame(doFit);
|
||||
setTimeout(doFit, 50);
|
||||
setTimeout(doFit, 150);
|
||||
setTimeout(doFit, 400);
|
||||
|
||||
// Forward user keystrokes to the backend
|
||||
term.onData((data) => {
|
||||
|
||||
Reference in New Issue
Block a user