Security Fixes

internal/recording/recorder_test.go

@@ -163,3 +163,121 @@ func TestDoubleClose(t *testing.T) {
 		t.Fatalf("second Close failed: %v", err)
 	}
 }
+
+func TestRecorderStopsAtSizeLimit(t *testing.T) {
+	dir := t.TempDir()
+	rec, err := newRecorderWithLimit(dir, "limited", "Limited", 80, 24, 512)
+	if err != nil {
+		t.Fatalf("newRecorderWithLimit failed: %v", err)
+	}
+
+	for i := 0; i < 50; i++ {
+		rec.WriteOutput([]byte(strings.Repeat("x", 80)))
+	}
+	if rec.EventCount() >= 50 {
+		t.Fatalf("expected recording to stop before all events were written")
+	}
+	if err := rec.Close(); err != nil {
+		t.Fatalf("Close failed: %v", err)
+	}
+	info, err := os.Stat(filepath.Join(dir, "limited.cast"))
+	if err != nil {
+		t.Fatalf("stat failed: %v", err)
+	}
+	if info.Size() > 512 {
+		t.Fatalf("recording size = %d, want <= 512", info.Size())
+	}
+}
+
+func TestStoreGetRejectsOversizedPlayback(t *testing.T) {
+	dir := t.TempDir()
+	path := filepath.Join(dir, "huge.cast")
+	header := `{"version":2,"width":80,"height":24,"timestamp":1}` + "\n"
+	if err := os.WriteFile(path, []byte(header+strings.Repeat("x", 256)), 0600); err != nil {
+		t.Fatalf("write failed: %v", err)
+	}
+
+	store := NewStore(dir)
+	_, _, err := store.getWithLimit("huge", 128)
+	if err == nil {
+		t.Fatal("expected oversized playback to be rejected")
+	}
+	if !strings.Contains(err.Error(), "too large") {
+		t.Fatalf("error = %q, want too large", err.Error())
+	}
+}
+
+func TestStoreCleanupByAgeAndSize(t *testing.T) {
+	dir := t.TempDir()
+	makeRecording := func(id string, created time.Time, payload string) {
+		rec, err := NewRecorder(dir, id, id, 80, 24)
+		if err != nil {
+			t.Fatalf("NewRecorder(%s) failed: %v", id, err)
+		}
+		rec.WriteOutput([]byte(payload))
+		if err := rec.Close(); err != nil {
+			t.Fatalf("Close(%s) failed: %v", id, err)
+		}
+		path := filepath.Join(dir, id+".cast")
+		data, err := os.ReadFile(path)
+		if err != nil {
+			t.Fatalf("ReadFile(%s) failed: %v", id, err)
+		}
+		parts := strings.SplitN(string(data), "\n", 2)
+		var hdr Header
+		if err := json.Unmarshal([]byte(parts[0]), &hdr); err != nil {
+			t.Fatalf("header parse(%s) failed: %v", id, err)
+		}
+		hdr.Timestamp = created.Unix()
+		line, err := marshalJSONLine(hdr)
+		if err != nil {
+			t.Fatalf("header encode(%s) failed: %v", id, err)
+		}
+		rest := ""
+		if len(parts) == 2 {
+			rest = parts[1]
+		}
+		if err := os.WriteFile(path, append(line, []byte(rest)...), 0600); err != nil {
+			t.Fatalf("WriteFile(%s) failed: %v", id, err)
+		}
+		if err := os.Chtimes(path, created, created); err != nil {
+			t.Fatalf("Chtimes(%s) failed: %v", id, err)
+		}
+	}
+
+	old := time.Now().Add(-45 * 24 * time.Hour)
+	recent := time.Now().Add(-2 * time.Hour)
+	makeRecording("old", old, "old")
+	makeRecording("recent", recent, strings.Repeat("recent", 50))
+
+	store := NewStore(dir)
+	result, err := store.Cleanup(30, 0)
+	if err != nil {
+		t.Fatalf("Cleanup by age failed: %v", err)
+	}
+	if result.Deleted != 1 {
+		t.Fatalf("deleted = %d, want 1", result.Deleted)
+	}
+	if _, err := os.Stat(filepath.Join(dir, "old.cast")); !os.IsNotExist(err) {
+		t.Fatalf("old recording still exists, stat err=%v", err)
+	}
+
+	info, err := store.StorageInfo()
+	if err != nil {
+		t.Fatalf("StorageInfo failed: %v", err)
+	}
+	result, err = store.Cleanup(0, info.TotalBytes-1)
+	if err != nil {
+		t.Fatalf("Cleanup by size failed: %v", err)
+	}
+	if result.Deleted != 1 {
+		t.Fatalf("deleted = %d, want 1", result.Deleted)
+	}
+}
+
+func TestStoreRejectsTraversalRecordingID(t *testing.T) {
+	store := NewStore(t.TempDir())
+	if err := store.Delete("../outside"); err == nil {
+		t.Fatal("expected traversal recording ID to be rejected")
+	}
+}