Andy DixonandClaude Opus 5.5
3ec5bd7e65
fix: pin parent directory and verify owner/type before trashing Trash renamed the item by path after the confirmation dialog, so a parent directory swapped for a symlink since the scan (e.g. by another user, while an administrator cleans their home) redirected the move to an unrelated file. The parent is now opened once and the item is checked (owner and file type as scanned) and renamed relative to that fd. macOS volume trash directories now get the same ownership/symlink checks as freedesktop.org ones on Linux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
73 lines
1.9 KiB
Go
73 lines
1.9 KiB
Go
package platform
|
|
|
|
import (
|
|
"errors"
|
|
"strconv"
|
|
"syscall"
|
|
"unsafe"
|
|
)
|
|
|
|
// TrashName is the user-facing name of the trash.
|
|
const TrashName = "Recycle Bin"
|
|
|
|
// Reveal selects the item in Explorer.
|
|
func Reveal(path string) error {
|
|
if err := checkAbs(path); err != nil {
|
|
return err
|
|
}
|
|
return startDetached("explorer.exe", "/select,", path)
|
|
}
|
|
|
|
var (
|
|
shell32 = syscall.NewLazyDLL("shell32.dll")
|
|
procSHFileOpertn = shell32.NewProc("SHFileOperationW")
|
|
)
|
|
|
|
// shFileOpStruct mirrors SHFILEOPSTRUCTW (64-bit natural alignment).
|
|
type shFileOpStruct struct {
|
|
hwnd uintptr
|
|
wFunc uint32
|
|
pFrom *uint16
|
|
pTo *uint16
|
|
fFlags uint16
|
|
fAnyOperationsAborted int32
|
|
hNameMappings uintptr
|
|
lpszProgressTitle *uint16
|
|
}
|
|
|
|
const (
|
|
foDelete = 0x3
|
|
fofSilent = 0x4
|
|
fofNoConfirmation = 0x10
|
|
fofAllowUndo = 0x40
|
|
fofNoErrorUI = 0x400
|
|
fofNoConfirmMkdir = 0x200
|
|
)
|
|
|
|
// Trash moves path to the Recycle Bin via SHFileOperationW with
|
|
// FOF_ALLOWUNDO. It never deletes permanently. want is not checked here:
|
|
// Windows exposes no owner or inode identity through the scan.
|
|
func Trash(path string, _ Expect) error {
|
|
if err := checkAbs(path); err != nil {
|
|
return err
|
|
}
|
|
if unsafe.Sizeof(uintptr(0)) != 8 {
|
|
return errors.New("recycle bin support requires a 64-bit build")
|
|
}
|
|
u, err := syscall.UTF16FromString(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
u = append(u, 0) // double NUL terminated list
|
|
op := shFileOpStruct{wFunc: foDelete, pFrom: &u[0],
|
|
fFlags: fofAllowUndo | fofNoConfirmation | fofSilent | fofNoErrorUI | fofNoConfirmMkdir}
|
|
r, _, _ := procSHFileOpertn.Call(uintptr(unsafe.Pointer(&op)))
|
|
if r != 0 {
|
|
return errors.New("SHFileOperation failed: code " + strconv.Itoa(int(r)))
|
|
}
|
|
if op.fAnyOperationsAborted != 0 {
|
|
return errors.New("operation aborted")
|
|
}
|
|
return nil
|
|
}
|