fix: suppress verbose PHP errors and bound login/audit housekeeping cost #41

Merged
GeoffMoore1979 merged 1 commits from feature/media-users-pages into master 2026-10-02 12:28:28 +02:00
1 Commits
Author SHA1 Message Date
Geoff MooreandClaude Sonnet 5 43200d7dfe fix: suppress verbose PHP errors and bound login/audit housekeeping cost
- bootstrap.php: disable display_errors/display_startup_errors in favour of
  PHP's own error log, so an uncaught engine error can never leak a stack
  trace or filesystem path to a client.
- LoginRateLimiter: cap tracked address/identity buckets at 20000, evicting
  the least recently active first, so a distributed flood of distinct
  addresses or login names cannot grow login-attempts.json without bound.
- Logger: prune expired audit logs probabilistically (1-in-100) instead of
  on every request, since every request already builds a Logger and a full
  directory scan on each one scales with total rotated log files.

Found during a self-review security audit; full findings available on
request.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-02 11:24:00 +01:00